Messages in this thread |  | | From | Andy Shevchenko <> | | Date | Mon, 13 Jan 2025 21:20:53 +0200 | | Subject | Re: [PATCH v6 00/10] i2c: riic: Add support for I2C bus recovery, along with driver cleanup and improvements |
| |
On Mon, Jan 13, 2025 at 2:26 PM Prabhakar <prabhakar.csengg@gmail.com> wrote: > > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > Hi All, > > This patch series introduces support for I2C bus recovery in the RIIC > driver, which is utilized in RZ series SoCs. The addition of bus recovery > functionality enhances the reliability of the I2C interface by allowing it > to recover from error conditions that might leave the bus in an unusable > state. > > Alongside the bus recovery implementation, the series includes several > cleanup and improvement patches that simplify and modernize the driver > code. These include replacing `dev_err` calls with `dev_err_probe`, > consistent usage of the `BIT` and `GENMASK` macros, leveraging devres > helpers for reset management, and improving code readability by marking > static data as `const`.
Looks very good to me now, thank you. FWIW, Reviewed-by: Andy Shevchenko <andy@kernel.org>
-- With Best Regards, Andy Shevchenko
|  |