Messages in this thread |  | | Date | Tue, 6 Aug 2024 18:01:26 +0100 | | From | Cristian Marussi <> | | Subject | Re: [PATCH v3 0/9] Make SCMI transport as standalone drivers |
| |
On Tue, Aug 06, 2024 at 09:47:17AM -0700, Florian Fainelli wrote: > On 7/30/24 06:33, Cristian Marussi wrote: > > Hi all, > > > > Till now the SCMI transport layer was being built embedded into in the core > > SCMI stack. > > > > Some of these transports, despite being currently part of the main SCMI > > module, are indeed also registered with different subsystems like optee or > > virtio, and actively probed also by those: this led to a few awkward and > > convoluted tricks to properly handle such interactions at boot time in the > > SCMI stack. > > > > Moreover some partner expressed the desire to be able to fully modularize > > the transports components. > > > > This series aim to make all such transports as standalone drivers that can > > be optionally loaded as modules. > > > > In order to do this, at first some new mechanism is introduced to support > > this new capability while maintaining, in parallel, the old legacy embedded > > transports; then each transport, one by one, is transitioned to be a > > standalone driver and finally the old legacy support for embedded transport > > is removed. > > > > Patch [1/9] is a fix around the chan_free method for OPTEE transport; it is > > really unrelated to this series, but included to avoid conflicts. > > > > Patch [2/9] is a mostly unrelated (but much needed) clean-up from Peng, > > which I included in this series to avoid conflicts at merge. > > > > Patch [3/9] simply collects the existing datagram manipulation helpers in a > > pair of function pointers structures, in preparation for later reworks. > > > > Patch [4/9] adds the bulk of the new logic to the core SCMI stack and then > > each existing transport is transitioned to be a standalone driver in > > patches 5,6,7,8 while shuffling around the compatibles. (no DT change is > > needed of curse for backward compatibility) > > While doing this I kept the module authorship in line with the main > > author(S) as spitted out by git-blame. > > > > Finally patch [9/9] removes all the legacy dead code from the core SCMI > > stack. > > > > No new symbol EXPORT has been added. > > > > The new transport drivers have been tested, as built-in and LKM, as > > follows: > > > > - mailbox on JUNO > > - virtio on emulation > > - optee on QEMU/optee using Linaro setup > > > > Exercised using the regular SCMI drivers stack and the SCMI ACS suite, > > testing commands, replies, delayed responses and notification. > > > > Multiple virtual SCMI instances support has been tested too. > > > > SMC has NOT been tested/exercised at run-time, only compile-tested. > > (due to lack of hardware) > > > > Note that in this new setup, all the probe deferral and retries between the > > SCMI core stack and the transports has been removed, since no more needed. > > > > Moreover the new drivers have been tested also with a fully modularized > > SCMI stack, i.e.: > > > > scmi-core.ko + scmi-module.ko + scmi_transport_*.ko [ + vendor modules ] > > > > Based on v6.11-rc1 > > > > Any feedback, and especially testing (:D) is welcome. > > Tested-by: Florian Fainelli <florian.fainelli@broadcom.com>
Thanks ! Cristian
|  |