lkml.org 
[lkml]   [2024]   [Aug]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 09/19] lib: test_objpool: Use kthread_run_on_cpu()
From
On 2024/8/8 00:02, Frederic Weisbecker wrote:
> Use the proper API instead of open coding it.
>
> Signed-off-by: Frederic Weisbecker <frederic@kernel.org>
> ---
> lib/test_objpool.c | 19 +++++--------------
> 1 file changed, 5 insertions(+), 14 deletions(-)
>
> diff --git a/lib/test_objpool.c b/lib/test_objpool.c
> index bfdb81599832..2c09dd91e731 100644
> --- a/lib/test_objpool.c
> +++ b/lib/test_objpool.c
> @@ -371,14 +371,10 @@ static int ot_start_sync(struct ot_test *test)
> if (!cpu_online(cpu))
> continue;
>
> - work = kthread_create_on_node(ot_thread_worker, item,
> - cpu_to_node(cpu), "ot_worker_%d", cpu);
> - if (IS_ERR(work)) {
> + work = kthread_run_on_cpu(ot_thread_worker, item,
> + cpu, "ot_worker_%d");
> + if (IS_ERR(work))
> pr_err("failed to create thread for cpu %d\n", cpu);
> - } else {
> - kthread_bind(work, cpu);
> - wake_up_process(work);
> - }
> }
>
> /* wait a while to make sure all threads waiting at start line */
> @@ -562,14 +558,9 @@ static int ot_start_async(struct ot_test *test)
> if (!cpu_online(cpu))
> continue;
>
> - work = kthread_create_on_node(ot_thread_worker, item,
> - cpu_to_node(cpu), "ot_worker_%d", cpu);
> - if (IS_ERR(work)) {
> + work = kthread_run_on_cpu(ot_thread_worker, item, cpu, "ot_worker_%d");
> + if (IS_ERR(work))
> pr_err("failed to create thread for cpu %d\n", cpu);
> - } else {
> - kthread_bind(work, cpu);
> - wake_up_process(work);
> - }
> }
>
> /* wait a while to make sure all threads waiting at start line */

Looks good to me. Thanks for the simplification.

Reviewed-by: Matt Wu <wuqiang.matt@bytedance.com>

\
 
 \ /
  Last update: 2024-08-14 04:54    [from the cache]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and my Meterkast|Read the blog