Messages in this thread | ![/](/images/icornerl.gif) | | Date | Tue, 11 Jun 2024 07:40:05 -0700 | Subject | Re: [PATCH v2 6/6] drivers/pci/hyperv/arm64: vPCI MSI IRQ domain from DT | From | Roman Kisel <> |
| |
On 6/7/2024 12:55 PM, Bjorn Helgaas wrote: > On Wed, May 15, 2024 at 01:12:38PM -0500, Bjorn Helgaas wrote: >> On Wed, May 15, 2024 at 09:34:09AM -0700, Roman Kisel wrote: >>> >>> >>> On 5/15/2024 2:48 AM, Saurabh Singh Sengar wrote: >>>> On Tue, May 14, 2024 at 03:43:53PM -0700, Roman Kisel wrote: >>>>> The hyperv-pci driver uses ACPI for MSI IRQ domain configuration >>>>> on arm64 thereby it won't be able to do that in the VTL mode where >>>>> only DeviceTree can be used. >>>>> >>>>> Update the hyperv-pci driver to discover interrupt configuration >>>>> via DeviceTree. >>>> >>>> Subject prefix should be "PCI: hv:" > > I forgot to also suggest that the subject line begin with a verb, > e.g., "Get vPCI MSI IRQ domain from DT" or similar, again so it reads > consistently with previous commits. > > Oh, I see patch 5/6, "Get the irq number from DeviceTree" is also very > similar. It would be nice if they matched, e.g., both used "IRQ" and > "DT". > > Bjorn
Will update, thanks! Going to send another version during the next week most likely.
-- Thank you, Roman
| ![\](/images/icornerr.gif) |