Messages in this thread | | | Subject | Re: [PATCH net-next v1] Revert "net: mirror skb frag ref/unref helpers" | From | patchwork-bot+netdevbpf@kernel ... | Date | Sat, 04 May 2024 00:30:29 +0000 |
| |
Hello:
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>:
On Thu, 2 May 2024 10:54:22 -0700 you wrote: > This reverts commit a580ea994fd37f4105028f5a85c38ff6508a2b25. > > This revert is to resolve Dragos's report of page_pool leak here: > https://lore.kernel.org/lkml/20240424165646.1625690-2-dtatulea@nvidia.com/ > > The reverted patch interacts very badly with commit 2cc3aeb5eccc ("skbuff: > Fix a potential race while recycling page_pool packets"). The reverted > commit hopes that the pp_recycle + is_pp_page variables do not change > between the skb_frag_ref and skb_frag_unref operation. If such a change > occurs, the skb_frag_ref/unref will not operate on the same reference type. > In the case of Dragos's report, the grabbed ref was a pp ref, but the unref > was a page ref, because the pp_recycle setting on the skb was changed. > > [...]
Here is the summary with links: - [net-next,v1] Revert "net: mirror skb frag ref/unref helpers" https://git.kernel.org/netdev/net-next/c/173e7622ccb3
You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
| |