lkml.org 
[lkml]   [2024]   [May]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v6 16/20] ARM: dts: aspeed: Add IBM P11 Fuji BMC system
From

On 5/28/24 09:08, Ninad Palsule wrote:
>
> Hi Eddie,
>
>> +
>> + led@6 {
>> + reg = <6>;
>> + default-state = "keep";
>> + label = "opencapi-connector5";
>> + retain-state-shutdown;
>> + type = <PCA955X_TYPE_LED>;
>> + };
> is led@7 not connected?


Correct.


>> +
>> + led@8 {
>> + reg = <8>;
>> + default-state = "keep";
>> + label = "vrm4";
>> + retain-state-shutdown;
>> + type = <PCA955X_TYPE_LED>;
>> + };
>> +
>> + led@9 {
>> + reg = <9>;
>> + default-state = "keep";
>> + label = "vrm5";
>> + retain-state-shutdown;
>> + type = <PCA955X_TYPE_LED>;
>> + };
>> +
>> + led@10 {
>> + reg = <10>;
>> + default-state = "keep";
>> + label = "vrm6";
>> + retain-state-shutdown;
>> + type = <PCA955X_TYPE_LED>;
>> + };
>> +
>> + led@11 {
>> + reg = <11>;
>> + default-state = "keep";
>> + label = "vrm7";
>> + retain-state-shutdown;
>> + type = <PCA955X_TYPE_LED>;
>> + };
>> +
>> + led@12 {
>> + reg = <12>;
>> + default-state = "keep";
>> + label = "vrm12";
>> + retain-state-shutdown;
>> + type = <PCA955X_TYPE_LED>;
>> + };
> curious about label jump from vrm7 to vrm12.


vrm0-3 and 8-11 are on the previous pca chip. I believe this is correct
based on the wiring in the spec, though the numberings are really just
convention established by the guy who managed the LEDs on the system.


>> + cfam4_i2c10: i2c-bus@a {
>> + reg = <10>; /* OP3A */
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> It will be more readable to have "reg" value in hex too. I have seen similar stuff in this FSI nodes. It will be consistent with other places.
>> +
>
> Reviewed-by: Ninad Palsule <ninad@linux.ibm.com>
>

Sure, thanks!

Eddie



\
 
 \ /
  Last update: 2024-05-28 16:48    [W:0.105 / U:0.604 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site