Messages in this thread | ![/](/images/icornerl.gif) | | From | Roland Xu <> | Subject | Re: [PATCH v2] rust: kernel: make impl_has_work compatible with more generics | Date | Wed, 22 May 2024 16:11:31 +0000 |
| |
Greg KH: > Columns are still not wrapped :(
Oh, sorry. I used `scripts/checkpatch.pl` and it only told me the commit title is too long, that's why I only change it.
________________________________________ From: Greg KH <gregkh@linuxfoundation.org> Sent: Wednesday, May 22, 2024 23:57 To: Roland Xu Cc: ojeda@kernel.org; boqun.feng@gmail.com; rust-for-linux@vger.kernel.org; linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] rust: kernel: make impl_has_work compatible with more generics
On Wed, May 22, 2024 at 11:45:33PM +0800, Roland Xu wrote: > v2: apply comments, wrap lines at 72 columns > ---
That goes below the --- line.
> Make the impl_has_work macro compatible with more complex generics such as lifetimes and const generic arguments.
Columns are still not wrapped :(
Look at example submissions on the mailing list for how to structure this.
thanks,
greg k-h
| ![\](/images/icornerr.gif) |