Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Wed, 22 May 2024 15:21:33 +0200 | Subject | Re: [PATCH v2 12/13] pinctrl: renesas: pinctrl-rzg2l: Add support for custom parameters |
| |
Hi Prabhakar,
On Tue, Apr 23, 2024 at 7:59 PM Prabhakar <prabhakar.csengg@gmail.com> wrote: > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > In preparation for passing custom params for RZ/V2H(P) SoC assign the > custom params that is being passed via struct rzg2l_pinctrl_data. > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > --- > RFC->v2 > - No change
Thanks for your patch!
> --- a/drivers/pinctrl/renesas/pinctrl-rzg2l.c > +++ b/drivers/pinctrl/renesas/pinctrl-rzg2l.c > @@ -262,6 +262,9 @@ struct rzg2l_pinctrl_data { > const struct rzg2l_hwcfg *hwcfg; > const struct rzg2l_variable_pin_cfg *variable_pin_cfg; > unsigned int n_variable_pin_cfg; > + unsigned int num_custom_params; > + const struct pinconf_generic_params *custom_params; > + const struct pin_config_item *custom_conf_items;
Perhaps this should be protected by #ifdef CONFIG_DEBUG_FS, too?
> void (*pwpr_pfc_unlock)(struct rzg2l_pinctrl *pctrl); > void (*pwpr_pfc_lock)(struct rzg2l_pinctrl *pctrl); > void (*pmc_writeb)(struct rzg2l_pinctrl *pctrl, u8 val, void __iomem *addr); > @@ -2374,6 +2377,13 @@ static int rzg2l_pinctrl_register(struct rzg2l_pinctrl *pctrl) > pctrl->desc.pmxops = &rzg2l_pinctrl_pmxops; > pctrl->desc.confops = &rzg2l_pinctrl_confops; > pctrl->desc.owner = THIS_MODULE; > + if (pctrl->data->num_custom_params) { > + pctrl->desc.num_custom_params = pctrl->data->num_custom_params; > + pctrl->desc.custom_params = pctrl->data->custom_params; > +#ifdef CONFIG_DEBUG_FS > + pctrl->desc.custom_conf_items = pctrl->data->custom_conf_items; > +#endif > + } > > pins = devm_kcalloc(pctrl->dev, pctrl->desc.npins, sizeof(*pins), GFP_KERNEL); > if (!pins)
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68korg
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |