Messages in this thread | ![/](/images/icornerl.gif) | | From | Stephen Boyd <> | Date | Wed, 22 May 2024 18:13:17 -0400 | Subject | Re: [PATCH] Bluetooth: qca: If memdump doesn't work, re-enable IBS |
| |
Quoting Douglas Anderson (2024-05-17 17:02:46) > On systems in the field, we are seeing this sometimes in the kernel logs: > Bluetooth: qca_controller_memdump() hci0: hci_devcd_init Return:-95 > > This means that _something_ decided that it wanted to get a memdump > but then hci_devcd_init() returned -EOPNOTSUPP (AKA -95). > > The cleanup code in qca_controller_memdump() when we get back an error > from hci_devcd_init() undoes most things but forgets to clear > QCA_IBS_DISABLED. One side effect of this is that, during the next > suspend, qca_suspend() will always get a timeout. > > Let's fix it so that we clear the bit. > > Fixes: 06d3fdfcdf5c ("Bluetooth: hci_qca: Add qcom devcoredump support") > Signed-off-by: Douglas Anderson <dianders@chromium.org> > ---
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
| ![\](/images/icornerr.gif) |