Messages in this thread | | | Date | Tue, 21 May 2024 15:50:44 -0500 | Subject | Re: [PATCH v7 0/3] platform/x86: dell: Implement platform_profile | From | Mario Limonciello <> |
| |
On 5/17/2024 17:42, Lyndon Sanche wrote: > v7: > - Move platform_profile into new dell-pc module > - Add myself as maintainer of dell-pc > - Move smbios call and fill functions to dell-smbios-base > - Check for classes above 30 and return as not supported > - Rename dell_laptop_check_supported_cmds to > dell_smbios_class_is_supported > - Check for ENXIO and treat as no thermal modes supported > v6: > - Add ACPI dependency for dell-laptop > - Add and use helper symbol for checking supported commands > v5: > - Fix indent in smbios-thermal-ctl comment > - Remove linux/wmi.h include > - Add 'select ACPI_PLATFORM_PROFILE' to Dell KConfig > v4: > - Make thermal_init and thermal_cleanup static > - Rearrange order of added includes, did not edit current includes > - Include bits.h > - Switch comment style > - Return error if platform_profile registering failed > - Add thermal calls to call_blacklist > - Align defines with tabs > - Correct separation of function and error handling > - Propagate error codes up > v3: > - Convert smbios-thermal-ctl docs to multiline comment and wrap > - Change thermal_mode_bits enum to directly be BIT() values > - Convert related code to use this > - Use FIELD_GET/PREP and GENNMASK for getting/setting thermal modes > - Correct offset for getting current ACC mode, setting offset > unchanged > - Check if thermal_handler is allocated before freeing and > unregistering platform_profile > v2: > - Wrap smbios-thermal-ctl comment > - Return proper error code when invalid state returned > - Simplify platform_profile_get returns > - Propogate ENOMEM error > > Lyndon Sanche (3): > platform/x86: dell-smbios: Add helper for checking supported class > platform/x86: dell-smbios: Move request functions for reuse > platform/x86: dell-pc: Implement platform_profile > > MAINTAINERS | 6 + > drivers/platform/x86/dell/Kconfig | 13 + > drivers/platform/x86/dell/Makefile | 1 + > drivers/platform/x86/dell/dell-laptop.c | 23 -- > drivers/platform/x86/dell/dell-pc.c | 310 +++++++++++++++++++ > drivers/platform/x86/dell/dell-smbios-base.c | 35 +++ > drivers/platform/x86/dell/dell-smbios.h | 7 + > 7 files changed, 372 insertions(+), 23 deletions(-) > create mode 100644 drivers/platform/x86/dell/dell-pc.c >
Series looks good to me, thanks.
Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
| |