Messages in this thread | ![/](/images/icornerl.gif) | | Date | Mon, 20 May 2024 12:03:00 +0200 | Subject | Re: [PATCH 3/4] arm64: dts: mediatek: mt8365: drop incorrect power-domain-cells | From | Krzysztof Kozlowski <> |
| |
On 20/05/2024 11:58, AngeloGioacchino Del Regno wrote: > Il 18/05/24 23:11, Krzysztof Kozlowski ha scritto: >> The top SCPSYS node is not a power domain provider. It's child >> "power-controller" is instead. Fix dtbs_check warnings like: >> >> mt8365-evk.dtb: syscon@10006000: '#power-domain-cells' does not match any of the regexes: 'pinctrl-[0-9]+' >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > Well if you're fixing that by migrating to scpsys compatible, you might as well > resolve all of the warnings in one commit, removing that power-domain-cells > property in patch [2/4], otherwise this one is technically a fix for that. > > Please squash [2/4] and [3/4], like that it just makes more sense. >
That's independent thing. Previous compatible - syscfg - also did not allow power domains. The difference is that bindings did not print a warning without my change. We can reverse the patches if this is more suitable.
Best regards, Krzysztof
| ![\](/images/icornerr.gif) |