lkml.org 
[lkml]   [2024]   [May]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 01/13] a2b: add A2B driver core
From

> +++ b/drivers/a2b/a2b.c
> @@ -0,0 +1,1252 @@

> +static int a2b_node_uevent(const struct device *dev,
> + struct kobj_uevent_env *env)
> +{

> + if (add_uevent_var(env, "A2B_NODE_VENDOR=%02x", node->vendor))
> + return -ENOMEM;

> + if (add_uevent_var(env, "A2B_NODE_VERSION=%02x", node->version))
> + return -ENOMEM;



I suggest to merge three if statements into one in a branch of
this function implementation.

Regards,
Markus

\
 
 \ /
  Last update: 2024-05-19 13:19    [W:0.263 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site