Messages in this thread | ![/](/images/icornerl.gif) | | Date | Sun, 19 May 2024 18:09:42 +0100 | From | Jonathan Cameron <> | Subject | Re: [PATCH v2 6/9] iio: adc: ad7173: Add ad7173_device_info names |
| |
On Thu, 16 May 2024 11:43:17 -0500 David Lechner <dlechner@baylibre.com> wrote:
> On Thu, May 16, 2024 at 11:09 AM Ceclan, Dumitru > <mitrutzceclan@gmail.com> wrote: > > > > On 16/05/2024 02:32, David Lechner wrote: > > > On Tue, May 14, 2024 at 2:23 AM Dumitru Ceclan via B4 Relay > > > <devnull+dumitru.ceclan.analog.com@kernel.org> wrote: > > >> > > >> From: Dumitru Ceclan <dumitru.ceclan@analog.com> > > >> > > >> Add missing names from the device info struct for 3 models to ensure > > >> consistency with the rest of the models. > > >> > > > > > > This affects userspace, right? So probably needs a Fixes: to make sure > > > this gets into the 6.10 release? > > > > > I don't think that it breaks userspace, just creates an additional file. > > > > This creates the file "name" in the iio:deviceX directory that reads the > > string. I do not consider the Fixes: tag a necessity. I consider that it > > resolves inconsistencies in the _device_info struct. > > Ah, OK. For some reason, I was thinking that it would default to the > driver name if this was left out.
Hmm. I'd be tempted to take this a fix as some userspace code relies on that name being present and it is unusual to not see it.
Jonathan
| ![\](/images/icornerr.gif) |