Messages in this thread | ![/](/images/icornerl.gif) | | Date | Thu, 16 May 2024 09:43:48 +0100 | From | Simon Horman <> | Subject | Re: [PATCH net] nfc: nci: Fix handling of zero-length payload packets in nci_rx_work() |
| |
Hi Yasuoka-san,
On Thu, May 16, 2024 at 12:17:07AM +0900, Ryosuke Yasuoka wrote: > When nci_rx_work() receives a zero-length payload packet, it should > discard the packet without exiting the loop. Instead, it should continue > processing subsequent packets.
nit: I think it would be clearer to say:
.. it should not discard the packet and exit the loop. Instead, ...
> > Fixes: d24b03535e5e ("nfc: nci: Fix uninit-value in nci_dev_up and nci_ntf_packet") > Closes: https://lore.kernel.org/lkml/20240428134525.GW516117@kernel.org/T/
nit: I'm not sure this Closes link is adding much, there are more changes coming, right?
> Reported-by: Ryosuke Yasuoka <ryasuoka@redhat.com> > Signed-off-by: Ryosuke Yasuoka <ryasuoka@redhat.com> > --- > net/nfc/nci/core.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/net/nfc/nci/core.c b/net/nfc/nci/core.c > index b133dc55304c..f2ae8b0d81b9 100644 > --- a/net/nfc/nci/core.c > +++ b/net/nfc/nci/core.c > @@ -1518,8 +1518,7 @@ static void nci_rx_work(struct work_struct *work) > > if (!nci_plen(skb->data)) { > kfree_skb(skb); > - kcov_remote_stop(); > - break; > + continue; > } > > /* Process frame */ > -- > 2.44.0 > >
| ![\](/images/icornerr.gif) |