Messages in this thread | ![/](/images/icornerl.gif) | | Date | Tue, 14 May 2024 13:29:43 +0100 | From | Conor Dooley <> | Subject | Re: [PATCH 1/3] mailbox: Make BCM2835_MBOX default to ARCH_BCM2835 |
| |
On Mon, May 13, 2024 at 04:52:32PM -0700, Florian Fainelli wrote: > This driver is depended on by CONFIG_FIRMWARE_RASPBERRYPI which provides > a number of essential services, including but not limited to a Linux > common clock framework provider. Make sure that enable > CONFIG_ARCH_BCM2835 does enable the corresponding mailbox driver. > > Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com> > --- > drivers/mailbox/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/mailbox/Kconfig b/drivers/mailbox/Kconfig > index 42940108a187..2b4cde562a90 100644 > --- a/drivers/mailbox/Kconfig > +++ b/drivers/mailbox/Kconfig > @@ -109,6 +109,7 @@ config ALTERA_MBOX > config BCM2835_MBOX > tristate "BCM2835 Mailbox" > depends on ARCH_BCM2835 > + default ARCH_BCM2835
This is just "default y", since I doubt ARCH_BCM2835 can be a module?
If so, patch 2 could also just be "default y" and I think patch 3 can have the same logic applied to it, given you're defaulting it to a dependency also?
Thanks, Conor.
> help > An implementation of the BCM2385 Mailbox. It is used to invoke > the services of the Videocore. Say Y here if you want to use the > -- > 2.34.1 > [unhandled content-type:application/pgp-signature] | ![\](/images/icornerr.gif) |