Messages in this thread | | | From | Shengjiu Wang <> | Date | Tue, 14 May 2024 15:22:12 +0800 | Subject | Re: [PATCH v2 2/4] clk: imx: clk-audiomix: Add reset controller |
| |
On Fri, May 10, 2024 at 12:02 PM Shengjiu Wang <shengjiu.wang@gmailcom> wrote: > > On Fri, May 10, 2024 at 6:04 AM Stephen Boyd <sboyd@kernel.org> wrote: > > > > Quoting Shengjiu Wang (2024-05-08 18:43:56) > > > Audiomix block control can be a reset controller for > > > Enhanced Audio Return Channel (EARC), which is one of > > > modules in this audiomix subsystem. > > > > > > The EARC PHY software reset and EARC controller software > > > reset need to be supported. > > > > Can you move this to drivers/reset and use auxiliary device APIs to do > > that? The idea would be to have reset maintainers review reset code. > > Thanks for your comments. > > This is a minor reset control only for XCVR devices, two reset bits > are accessed. > > If we move to an auxiliary device, we need to define a new header file > and a new driver, which will bring more code size and complexity. > > So is it necessary to separate it to another auxiliary driver/device? > > And add Philipp Zabel in loop for review. >
I will use syscon and simple-mfd to separate the reset function to a new driver, which will be a child node of the audiomix device.
Best regards Shengjiu Wang
| |