Messages in this thread |  | | Date | Sun, 12 May 2024 13:04:50 +0100 | | From | Conor Dooley <> | | Subject | Re: [PATCH v2 1/5] dt-bindings: input: touchscreen: himax,hx83112b: add HX83100A |
| |
On Sat, May 11, 2024 at 10:10:08AM -0400, Felix Kaechele wrote: > On 2024-05-11 08:38, Conor Dooley wrote: > > On Sat, May 11, 2024 at 08:12:22AM -0400, Felix Kaechele wrote: > > > Add a compatible string for the Himax HX83100A touch controller. > > > > > > Signed-off-by: Felix Kaechele <felix@kaechele.ca> > > > > Commit message should mention what makes this device incompatible with > > the existing device. > > Thanks! > > I have added this note in the commit message which will be part of a v3, > coming after I hopefully receive a few more comments on the other parts of > this change: > > The HX83100A presents touch events on its internal bus rather than offering > a dedicated event register like the other chips in this family do.
Ye, that sounds good. W/ that, Acked-by: Conor Dooley <conor.dooley@microchip.com>
Cheers, Conor.
[unhandled content-type:application/pgp-signature] |  |