lkml.org 
[lkml]   [2024]   [Apr]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v2 1/5] clk: Remove prepare_lock hold assertion in __clk_release()
    From
    Date
    Quoting Stephen Boyd (2024-03-25 11:41:55)
    > Removing this assertion lets us move the kref_put() call outside the
    > prepare_lock section. We don't need to hold the prepare_lock here to
    > free memory and destroy the clk_core structure. We've already unlinked
    > the clk from the clk tree and by the time the release function runs
    > nothing holds a reference to the clk_core anymore so anything with the
    > pointer can't access the memory that's being freed anyway. Way back in
    > commit 496eadf821c2 ("clk: Use lockdep asserts to find missing hold of
    > prepare_lock") we didn't need to have this assertion either.
    >
    > Fixes: 496eadf821c2 ("clk: Use lockdep asserts to find missing hold of prepare_lock")
    > Cc: Krzysztof Kozlowski <krzk@kernel.org>
    > Reviewed-by: Douglas Anderson <dianders@chromium.org>
    > Signed-off-by: Stephen Boyd <sboyd@kernel.org>
    > ---

    Applied to clk-fixes

    \
     
     \ /
      Last update: 2024-05-27 16:28    [W:5.590 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site