Messages in this thread | | | Subject | Re: [PATCH v2 1/5] clk: Remove prepare_lock hold assertion in __clk_release() | From | Stephen Boyd <> | Date | Sun, 07 Apr 2024 19:35:40 -0700 |
| |
Quoting Stephen Boyd (2024-03-25 11:41:55) > Removing this assertion lets us move the kref_put() call outside the > prepare_lock section. We don't need to hold the prepare_lock here to > free memory and destroy the clk_core structure. We've already unlinked > the clk from the clk tree and by the time the release function runs > nothing holds a reference to the clk_core anymore so anything with the > pointer can't access the memory that's being freed anyway. Way back in > commit 496eadf821c2 ("clk: Use lockdep asserts to find missing hold of > prepare_lock") we didn't need to have this assertion either. > > Fixes: 496eadf821c2 ("clk: Use lockdep asserts to find missing hold of prepare_lock") > Cc: Krzysztof Kozlowski <krzk@kernel.org> > Reviewed-by: Douglas Anderson <dianders@chromium.org> > Signed-off-by: Stephen Boyd <sboyd@kernel.org> > ---
Applied to clk-fixes
| |