Messages in this thread | | | Date | Sun, 7 Apr 2024 12:21:39 -0700 | From | Reinette Chatre <> | Subject | Re: [PATCH v1 5/6] x86/resctrl: Abstract PQR_ASSOC from generic code |
| |
Hi Peter,
On 3/25/2024 10:27 AM, Peter Newman wrote: > While CLOSID and RMID originated in RDT, the concept applies to other > architectures, as it's standard to write allocation and monitoring IDs > into per-CPU registers. > > - Rename resctrl_pqr_state and pqr_state to be more > architecturally-neutral. > > - Introduce resctrl_arch_update_cpu() to replace the explicit write to > MSR_IA32_PQR_ASSOC in __resctrl_sched_in(). In the case of MPAM, > PARTID[_I,D] and PMG are a simple function of closid, rmid, and an > internal global. > > - Update terminology containing explicit references to the PQR_ASSOC > register. > > Signed-off-by: Peter Newman <peternewman@google.com> > --- > arch/x86/kernel/cpu/resctrl/core.c | 11 ++++++++--- > arch/x86/kernel/cpu/resctrl/internal.h | 6 +++--- > arch/x86/kernel/cpu/resctrl/pseudo_lock.c | 4 ++-- > arch/x86/kernel/cpu/resctrl/rdtgroup.c | 18 +++++++++--------- > include/linux/resctrl.h | 11 +++++++++++ > 5 files changed, 33 insertions(+), 17 deletions(-)
Looks like __rdtgroup_move_task() still refers to the PQR MSR in comments and it eventually ends up in fs code.
Also found in arch/x86/kernel/process_{32,64}.c: /* Load the Intel cache allocation PQR MSR. */
Reinette
| |