Messages in this thread | | | Date | Sun, 7 Apr 2024 09:19:44 -0400 | Subject | Re: [PATCH v2 16/16] EDAC/mce_amd: Add support for FRU Text in MCA | From | Yazen Ghannam <> |
| |
On 4/5/24 12:06, Luck, Tony wrote: >> diff --git a/arch/x86/kernel/cpu/mce/core.c b/arch/x86/kernel/cpu/mce/core.c >> index aa27729f7899..a4d09dda5fae 100644 >> --- a/arch/x86/kernel/cpu/mce/core.c >> +++ b/arch/x86/kernel/cpu/mce/core.c >> @@ -207,6 +207,8 @@ static void __print_mce(struct mce_hw_err *err) >> pr_cont("SYND2 %llx ", err->vi.amd.synd2); >> if (m->ipid) >> pr_cont("IPID %llx ", m->ipid); >> + if (err->vi.amd.config) > > This is in common code. If other vendors start adding their own stuff to the > "vi" union you might incorrectly print this. Add a vendor check before looking > at values inside "m->vi". >
Yes, agreed. Will do.
Thanks, Yazen
| |