Messages in this thread |  | | Date | Fri, 5 Apr 2024 09:24:21 +0200 | | Subject | Re: [PATCH v3 02/14] mm/ksm: use folio in remove_rmap_item_from_tree | | From | David Hildenbrand <> |
| |
On 25.03.24 13:48, alexs@kernel.org wrote: > From: "Alex Shi (tencent)" <alexs@kernel.org> > > To save 2 compound_head calls. > > Signed-off-by: Alex Shi (tencent) <alexs@kernel.org> > Cc: Izik Eidus <izik.eidus@ravellosystems.com> > Cc: Matthew Wilcox <willy@infradead.org> > Cc: Andrea Arcangeli <aarcange@redhat.com> > Cc: Hugh Dickins <hughd@google.com> > Cc: Chris Wright <chrisw@sous-sol.org> > --- > mm/ksm.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/mm/ksm.c b/mm/ksm.c > index ac080235b002..ea3dabf71e47 100644 > --- a/mm/ksm.c > +++ b/mm/ksm.c > @@ -1006,16 +1006,16 @@ static void remove_rmap_item_from_tree(struct ksm_rmap_item *rmap_item) > { > if (rmap_item->address & STABLE_FLAG) { > struct ksm_stable_node *stable_node; > - struct page *page; > + struct folio *folio; > > stable_node = rmap_item->head; > - page = get_ksm_page(stable_node, GET_KSM_PAGE_LOCK); > - if (!page) > + folio = ksm_get_folio(stable_node, GET_KSM_PAGE_LOCK); > + if (!folio) > goto out; > > hlist_del(&rmap_item->hlist); > - unlock_page(page); > - put_page(page); > + folio_unlock(folio); > + folio_put(folio); > > if (!hlist_empty(&stable_node->hlist)) > ksm_pages_sharing--;
Reviewed-by: David Hildenbrand <david@redhat.com>
-- Cheers,
David / dhildenb
|  |