[lkml]   [2024]   [Apr]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH net v2] vsock/virtio: fix packet delivery to tap device

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <>:

On Fri, 29 Mar 2024 17:12:59 +0100 you wrote:
> Commit 82dfb540aeb2 ("VSOCK: Add virtio vsock vsockmon hooks") added
> virtio_transport_deliver_tap_pkt() for handing packets to the
> vsockmon device. However, in virtio_transport_send_pkt_work(),
> the function is called before actually sending the packet (i.e.
> before placing it in the virtqueue with virtqueue_add_sgs() and checking
> whether it returned successfully).
> Queuing the packet in the virtqueue can fail even multiple times.
> However, in virtio_transport_deliver_tap_pkt() we deliver the packet
> to the monitoring tap interface only the first time we call it.
> This certainly avoids seeing the same packet replicated multiple times
> in the monitoring interface, but it can show the packet sent with the
> wrong timestamp or even before we succeed to queue it in the virtqueue.
> [...]

Here is the summary with links:
- [net,v2] vsock/virtio: fix packet delivery to tap device

You are awesome, thank you!
Deet-doot-dot, I am a bot.

 \ /
  Last update: 2024-04-03 03:10    [W:0.047 / U:0.164 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site