Messages in this thread | | | From | POPESCU Catalin <> | Subject | Re: [PATCH net-next v2] net: phy: dp8382x: keep WOL settings across suspends | Date | Wed, 3 Apr 2024 07:15:07 +0000 |
| |
On 03/04/2024 02:45, Jakub Kicinski wrote: > [Some people who received this message don't often get email from kuba@kernel.org. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ] > > This email is not from Hexagon’s Office 365 instance. Please be careful while clicking links, opening attachments, or replying to this email. > > > On Thu, 28 Mar 2024 14:33:58 +0100 Catalin Popescu wrote: >> -static int dp83822_set_wol(struct phy_device *phydev, >> - struct ethtool_wolinfo *wol) >> +static int _dp83822_set_wol(struct phy_device *phydev, >> + struct ethtool_wolinfo *wol) > Why the underscore, you can all this any number of things maybe > dp83822_config_wol() or dp83822_apply_wol()?
Sure, I'll use dp83822_config_wol.
| |