Messages in this thread | ![/](/images/icornerl.gif) | | Date | Wed, 3 Apr 2024 15:37:11 -0700 | From | Elliot Berman <> | Subject | Re: [PATCH] firmware: qcom: qcm: fix unused qcom_scm_qseecom_allowlist |
| |
On Mon, Nov 20, 2023 at 07:56:23PM +0100, Krzysztof Kozlowski wrote: > For !OF builds, the qcom_scm_qseecom_allowlist is unused: > > drivers/firmware/qcom/qcom_scm.c:1652:34: error: ‘qcom_scm_qseecom_allowlist’ defined but not used [-Werror=unused-const-variable=] > > Fixes: 00b1248606ba ("firmware: qcom_scm: Add support for Qualcomm Secure Execution Environment SCM interface") > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202311191654.S4wlVUrz-lkp@intel.com/ > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Elliot Berman <quic_eberman@quicinc.com>
Hope this helps bump it :)
> --- > drivers/firmware/qcom/qcom_scm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/firmware/qcom/qcom_scm.c b/drivers/firmware/qcom/qcom_scm.c > index 520de9b5633a..ecdb367dc9b8 100644 > --- a/drivers/firmware/qcom/qcom_scm.c > +++ b/drivers/firmware/qcom/qcom_scm.c > @@ -1649,7 +1649,7 @@ EXPORT_SYMBOL_GPL(qcom_scm_qseecom_app_send); > * We do not yet support re-entrant calls via the qseecom interface. To prevent > + any potential issues with this, only allow validated machines for now. > */ > -static const struct of_device_id qcom_scm_qseecom_allowlist[] = { > +static const struct of_device_id qcom_scm_qseecom_allowlist[] __maybe_unused = { > { .compatible = "lenovo,thinkpad-x13s", }, > { } > }; > -- > 2.34.1 > >
| ![\](/images/icornerr.gif) |