lkml.org 
[lkml]   [2024]   [Apr]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2] usb: typec: ucsi: Wait 20ms before reading CCI after a reset
Hi Pavan,

On Wed, Apr 3, 2024 at 10:57 AM Pavan Holla <pholla@chromium.org> wrote:
>
> The PPM might take time to process a reset. Allow 20ms for the reset to
> be processed before reading the CCI.
>
> Signed-off-by: Pavan Holla <pholla@chromium.org>
> ---
> The PPM might take time to process a reset and set the CCI. Give the PPM
> 20ms to update it's CCI.
>
> Based on the discussion in v1, this should not slow down existing
> implementations because they would not set any bits in the CCI after a reset,
> and would take a 20ms delay to read the CCI anyway. This change just makes the
> delay explicit, and reduces a CCI read. Based on the spec, the PPM has
> 10ms to set busy, so, 20ms seems like a reasonable delay before we read
> the CCI.

The above information is helpful context, and should be included
in the commit message, otherwise it will get lost on patch application.

With that, feel free to add:
Reviewed-by: Prashant Malani <pmalani@chromium.org>

BR,

-Prashant

\
 
 \ /
  Last update: 2024-05-27 16:23    [W:0.027 / U:0.452 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site