Messages in this thread | ![/](/images/icornerl.gif) | | From | Daniel Latypov <> | Date | Wed, 3 Apr 2024 14:59:43 -0700 | Subject | Re: [PATCH v2] Documentation: kunit: Clarify test filter format |
| |
On Tue, Apr 2, 2024 at 5:51 AM Brendan Jackman <jackmanb@google.com> wrote: > > It seems obvious once you know, but at first I didn't realise that the > suite name is part of this format. Document it and add some examples. > > Signed-off-by: Brendan Jackman <jackmanb@google.com>
Reviewed-by: Daniel Latypov <dlatypov@google.com>
Thanks!
I agree with your comment on v1, I think the extra verbosity is fine. It's still easy to read and this should hopefully eliminate the ambiguity for most readers.
> --- > v1->v2: Expanded to clarify that suite_glob and test_glob are two separate > patterns. Also made some other trivial changes to formatting etc.
<snip>
| ![\](/images/icornerr.gif) |