| Date | Wed, 3 Apr 2024 20:45:17 +0200 | From | Pavel Machek <> | Subject | Re: [PATCH v3 09/25] media: i2c: imx258: Add support for running on 2 CSI data lanes |
| |
Hi!
> +/* > + * 4208x3120 @ 30 fps needs 1267Mbps/lane, 4 lanes. > + * To avoid further computation of clock settings, adopt the same per > + * lane data rate when using 2 lanes, thus allowing a maximum of 15fps. > + */ > +static const struct imx258_reg mipi_1267mbps_19_2mhz_2l[] = { > + { 0x0136, 0x13 }, > + { 0x0137, 0x33 }, > + { 0x0301, 0x0A }, > + { 0x0303, 0x02 }, > + { 0x0305, 0x03 }, > + { 0x0306, 0x00 }, > + { 0x0307, 0xC6 }, > + { 0x0309, 0x0A }, > + { 0x030B, 0x01 }, > + { 0x030D, 0x02 }, > + { 0x030E, 0x00 }, > + { 0x030F, 0xD8 }, > + { 0x0310, 0x00 }, > + > + { 0x0114, 0x01 }, > + { 0x0820, 0x09 }, > + { 0x0821, 0xa6 }, > + { 0x0822, 0x66 }, > + { 0x0823, 0x66 }, > +}; > + > +static const struct imx258_reg mipi_1267mbps_19_2mhz_4l[] = { > { 0x0136, 0x13 }, > { 0x0137, 0x33 }, > { 0x0301, 0x05 },
I wish we did not have to copy all the magic values like this.
Best regards, Pavel
-- People of Russia, stop Putin before his war on Ukraine escalates. [unhandled content-type:application/pgp-signature] |