lkml.org 
[lkml]   [2024]   [Apr]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 1/2] f2fs: fix to relocate check condition in f2fs_fallocate()
    Date
    compress and pinfile flag should be checked after inode lock held to
    avoid race condition, fix it.

    Fixes: 4c8ff7095bef ("f2fs: support data compression")
    Fixes: 5fed0be8583f ("f2fs: do not allow partial truncation on pinned file")
    Signed-off-by: Chao Yu <chao@kernel.org>
    ---
    fs/f2fs/file.c | 20 +++++++++++---------
    1 file changed, 11 insertions(+), 9 deletions(-)

    diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
    index 148bfe3effdf..83a807e25e31 100644
    --- a/fs/f2fs/file.c
    +++ b/fs/f2fs/file.c
    @@ -1820,15 +1820,6 @@ static long f2fs_fallocate(struct file *file, int mode,
    (mode & (FALLOC_FL_COLLAPSE_RANGE | FALLOC_FL_INSERT_RANGE)))
    return -EOPNOTSUPP;

    - /*
    - * Pinned file should not support partial truncation since the block
    - * can be used by applications.
    - */
    - if ((f2fs_compressed_file(inode) || f2fs_is_pinned_file(inode)) &&
    - (mode & (FALLOC_FL_PUNCH_HOLE | FALLOC_FL_COLLAPSE_RANGE |
    - FALLOC_FL_ZERO_RANGE | FALLOC_FL_INSERT_RANGE)))
    - return -EOPNOTSUPP;
    -
    if (mode & ~(FALLOC_FL_KEEP_SIZE | FALLOC_FL_PUNCH_HOLE |
    FALLOC_FL_COLLAPSE_RANGE | FALLOC_FL_ZERO_RANGE |
    FALLOC_FL_INSERT_RANGE))
    @@ -1836,6 +1827,17 @@ static long f2fs_fallocate(struct file *file, int mode,

    inode_lock(inode);

    + /*
    + * Pinned file should not support partial truncation since the block
    + * can be used by applications.
    + */
    + if ((f2fs_compressed_file(inode) || f2fs_is_pinned_file(inode)) &&
    + (mode & (FALLOC_FL_PUNCH_HOLE | FALLOC_FL_COLLAPSE_RANGE |
    + FALLOC_FL_ZERO_RANGE | FALLOC_FL_INSERT_RANGE))) {
    + ret = -EOPNOTSUPP;
    + goto out;
    + }
    +
    ret = file_modified(file);
    if (ret)
    goto out;
    --
    2.40.1

    \
     
     \ /
      Last update: 2024-05-27 16:22    [W:4.296 / U:0.048 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site