Messages in this thread | | | Date | Sat, 27 Apr 2024 09:50:42 +0800 | Subject | Re: [f2fs-dev] [PATCH] f2fs: zone: fix to don't trigger OPU on pinfile for direct IO | From | Chao Yu <> |
| |
On 2024/4/26 19:30, Zhiguo Niu wrote: > Dear Chao, > > On Fri, Apr 26, 2024 at 6:37 PM Chao Yu <chao@kernel.org> wrote: >> >> Otherwise, it breaks pinfile's sematics. >> >> Cc: Daeho Jeong <daeho43@gmail.com> >> Signed-off-by: Chao Yu <chao@kernel.org> >> --- >> fs/f2fs/data.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c >> index bee1e45f76b8..e29000d83d52 100644 >> --- a/fs/f2fs/data.c >> +++ b/fs/f2fs/data.c >> @@ -1596,7 +1596,8 @@ int f2fs_map_blocks(struct inode *inode, struct f2fs_map_blocks *map, int flag) >> >> /* use out-place-update for direct IO under LFS mode */ >> if (map->m_may_create && >> - (is_hole || (f2fs_lfs_mode(sbi) && flag == F2FS_GET_BLOCK_DIO))) { >> + (is_hole || (flag == F2FS_GET_BLOCK_DIO && (f2fs_lfs_mode(sbi) && >> + (!f2fs_sb_has_blkzoned(sbi) || !f2fs_is_pinned_file(inode)))))) { > Excuse me I a little question, should pin files not be written in OPU > mode regardless of device type(conventional or zone)?
Agreed, so it looks we need remove !f2fs_sb_has_blkzoned condition here...
Thanks,
> thanks! >> if (unlikely(f2fs_cp_error(sbi))) { >> err = -EIO; >> goto sync_out; >> -- >> 2.40.1 >> >> >> >> _______________________________________________ >> Linux-f2fs-devel mailing list >> Linux-f2fs-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
| |