Messages in this thread | ![/](/images/icornerl.gif) | | Date | Wed, 24 Apr 2024 22:26:35 +0200 | Subject | Re: [PATCH v1 2/5] firmware: microchip: don't unconditionally print validation success | From | Alexandre Ghiti <> |
| |
Hi Conor,
On 10/04/2024 13:58, Conor Dooley wrote: > From: Conor Dooley <conor.dooley@microchip.com> > > If validation fails, both prints are made. Skip the success one in the > failure case. > > Fixes: ec5b0f1193ad ("firmware: microchip: add PolarFire SoC Auto Update support") > Signed-off-by: Conor Dooley <conor.dooley@microchip.com> > --- > drivers/firmware/microchip/mpfs-auto-update.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/firmware/microchip/mpfs-auto-update.c b/drivers/firmware/microchip/mpfs-auto-update.c > index 33343e83373c..298ad21e139b 100644 > --- a/drivers/firmware/microchip/mpfs-auto-update.c > +++ b/drivers/firmware/microchip/mpfs-auto-update.c > @@ -218,10 +218,12 @@ static int mpfs_auto_update_verify_image(struct fw_upload *fw_uploader) > if (ret | response->resp_status) { > dev_warn(priv->dev, "Verification of Upgrade Image failed!\n"); > ret = ret ? ret : -EBADMSG; > + goto free_message; > } > > dev_info(priv->dev, "Verification of Upgrade Image passed!\n"); > > +free_message: > devm_kfree(priv->dev, message); > free_response: > devm_kfree(priv->dev, response);
This should go into -fixes, but not sure if you take care of this or if Palmer should, please let me know so that I can remove this from my list :)
Thanks,
Alex
| ![\](/images/icornerr.gif) |