Messages in this thread | ![/](/images/icornerl.gif) | | From | Namhyung Kim <> | Date | Tue, 23 Apr 2024 16:07:08 -0700 | Subject | Re: [PATCH] perf annotate: Fix data type profiling on stdio |
| |
On Tue, Apr 23, 2024 at 9:57 AM Ian Rogers <irogers@google.com> wrote: > > On Mon, Apr 22, 2024 at 7:06 PM Namhyung Kim <namhyung@kernel.org> wrote: > > > > The loop in hists__find_annotations() never set the 'nd' pointer to NULL > > and it makes stdio output repeating the last element forever. I think > > it doesn't set to NULL for TUI to prevent it from exiting unexpectedly. > > But it should just set on stdio mode. > > > > Fixes: d001c7a7f473 ("perf annotate-data: Add hist_entry__annotate_data_tui()") > > Signed-off-by: Namhyung Kim <namhyung@kernel.org> > > Acked-by: Ian Rogers <irogers@google.com>
Thanks for your review!
> > Should we have a test to cover things like this?
Ok, I'll try to add one for perf annotate.
Thanks, Namhyung
| ![\](/images/icornerr.gif) |