lkml.org 
[lkml]   [2024]   [Apr]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH -next] genirq: Reuse irq_is_nmi()
From


On 2024/4/23 5:01, Thomas Gleixner wrote:
> On Wed, Apr 17 2024 at 16:56, Jinjie Ruan wrote:
>>
>> +static bool __maybe_unused irq_is_nmi(struct irq_desc *desc)
>
> Seriously? What's wrong with static inline?

Use "static bool" has follwoing warning:

kernel/irq/internals.h:283:13: warning: ‘irq_is_nmi’ defined but not
used [-Wunused-function]
283 | static bool irq_is_nmi(struct irq_desc *desc)

But us "static inline bool" is ok.

I'll change it to inline, thank you very much!
>

\
 
 \ /
  Last update: 2024-04-23 04:17    [W:2.002 / U:1.464 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site