Messages in this thread Patch in this message | | | From | Changbin Du <> | Subject | [PATCH v2 1/2] perf trace beauty: Always show param if show_zero is set | Date | Tue, 23 Apr 2024 09:53:29 +0800 |
| |
For some parameters, it is best to also display them when they are 0, e.g. flags.
Signed-off-by: Changbin Du <changbin.du@huawei.com> --- tools/perf/builtin-trace.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c index e5fef39c34bf..a8407eee58a3 100644 --- a/tools/perf/builtin-trace.c +++ b/tools/perf/builtin-trace.c @@ -2099,9 +2099,9 @@ static size_t syscall__scnprintf_args(struct syscall *sc, char *bf, size_t size, !trace->show_zeros && !(sc->arg_fmt && (sc->arg_fmt[arg.idx].show_zero || - sc->arg_fmt[arg.idx].scnprintf == SCA_STRARRAY || - sc->arg_fmt[arg.idx].scnprintf == SCA_STRARRAYS) && - sc->arg_fmt[arg.idx].parm)) + ((sc->arg_fmt[arg.idx].scnprintf == SCA_STRARRAY || + sc->arg_fmt[arg.idx].scnprintf == SCA_STRARRAYS) && + sc->arg_fmt[arg.idx].parm)))) continue; printed += scnprintf(bf + printed, size - printed, "%s", printed ? ", " : ""); @@ -2803,8 +2803,8 @@ static size_t trace__fprintf_tp_fields(struct trace *trace, struct evsel *evsel, */ if (val == 0 && !trace->show_zeros && - !((arg->show_zero || - arg->scnprintf == SCA_STRARRAY || + !arg->show_zero && + !((arg->scnprintf == SCA_STRARRAY || arg->scnprintf == SCA_STRARRAYS) && arg->parm)) continue; -- 2.34.1
| |