lkml.org 
[lkml]   [2024]   [Apr]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 1/6] dt-bindings: HID: i2c-hid: add dedicated Ilitek ILI2901 schema
    From
    On 23/04/2024 15:46, Johan Hovold wrote:
    > The Ilitek ILI2901 touch screen controller was apparently incorrectly
    > added to the Elan eKTH6915 schema simply because it also has a reset
    > gpio and is currently managed by the Elan driver in Linux.
    >
    > The two controllers are not related even if an unfortunate wording in
    > the commit message adding the Ilitek compatible made it sound like they
    > were.
    >
    > Add a dedicated schema for the ILI2901 which does not specify the I2C
    > address (which is likely 0x41 rather than 0x10 as for other Ilitek touch
    > controllers) to avoid cluttering the Elan schema with unrelated devices
    > and to make it easier to find the correct schema when adding further
    > Ilitek controllers.
    >
    > Fixes: d74ac6f60a7e ("dt-bindings: HID: i2c-hid: elan: Introduce Ilitek ili2901")
    > Cc: Zhengqiao Xia <xiazhengqiao@huaqin.corp-partner.google.com>
    > Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
    > ---
    > .../bindings/input/elan,ekth6915.yaml | 5 +-
    > .../bindings/input/ilitek,ili2901.yaml | 66 +++++++++++++++++++
    > 2 files changed, 68 insertions(+), 3 deletions(-)
    > create mode 100644 Documentation/devicetree/bindings/input/ilitek,ili2901.yaml
    >
    > diff --git a/Documentation/devicetree/bindings/input/elan,ekth6915.yaml b/Documentation/devicetree/bindings/input/elan,ekth6915.yaml
    > index dc4ac41f2441..3e2d216c6432 100644
    > --- a/Documentation/devicetree/bindings/input/elan,ekth6915.yaml
    > +++ b/Documentation/devicetree/bindings/input/elan,ekth6915.yaml
    > @@ -18,9 +18,8 @@ allOf:
    >
    > properties:
    > compatible:
    > - enum:
    > - - elan,ekth6915
    > - - ilitek,ili2901
    > + items:

    Drop items, that's just const. Or keep it as enum, which makes patch
    diff smaller here.

    > + - const: elan,ekth6915

    With items dropped:

    Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

    Best regards,
    Krzysztof


    \
     
     \ /
      Last update: 2024-04-23 18:25    [W:2.957 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site