| Date | Mon, 22 Apr 2024 15:20:58 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH v8 08/16] x86/mm: Add generic guest initialization hook |
| |
On Thu, Feb 15, 2024 at 05:01:20PM +0530, Nikunj A Dadhania wrote: > diff --git a/arch/x86/mm/mem_encrypt.c b/arch/x86/mm/mem_encrypt.c > index d035bce3a2b0..68aa06852466 100644 > --- a/arch/x86/mm/mem_encrypt.c > +++ b/arch/x86/mm/mem_encrypt.c > @@ -89,6 +89,8 @@ void __init mem_encrypt_init(void) > /* Call into SWIOTLB to update the SWIOTLB DMA buffers */ > swiotlb_update_mem_attributes(); > > + x86_platform.guest.enc_init(); > + > print_mem_encrypt_feature_info();
Why all this hoopla if all you need is to call it once in mem_encrypt.c?
IOW, you can simply call snp_secure_tsc_prepare() there, no?
Those function pointers are to be used in generic code in order to hide all the platform-specific hackery but mem_encrypt.c is not really generic code, I'd say...
-- Regards/Gruss, Boris.
https://people.kernel.org/tglx/notes-about-netiquette
|