lkml.org 
[lkml]   [2024]   [Apr]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] drivers: use __free attribute instead of of_node_put()
On Fri, Apr 19, 2024 at 11:16:37PM +0530, Shresth Prasad wrote:
> > Please fix the subject line to be "backlight: <driver>: ...". I came
> > very close to deleting this patch without reading it ;-) .
>
> Really sorry about that, I'll fix it.
>
> > Do we need to get dev->of_node at all? The device, which we are
> > borrowing, already owns a reference to the node so I don't see
> > any point in this function taking an extra one.
> >
> > So why not simply make this:
> >
> > struct device_node *np = dev->of_node;
>
> Looking at it again, I'm not sure why the call to of_node_put is there in
> the first place. I think removing it would be fine.
>
> I'll fix both of these issues and send a patch v2.

I assume you are using lore "Reply using the --to, --cc, and..." option
or something similar.

You seem to have mixed up 2 different message ID. I was not able to make
any sense of this email.

You have wrongly used [1] but you really want [2]. I think both have
very similar $subject and hence the confusion. Another reason
why getting subject right is very important on the mailing list.

--
Regards,
Sudeep

[1] 20240419131956.665769-1-vincenzo.mezzela@gmail.com
(https://lore.kernel.org/all/20240419131956.665769-1-vincenzo.mezzela@gmail.com/)
[2] 20240419111613.GA12884@aspen.lan
https://lore.kernel.org/all/20240419111613.GA12884@aspen.lan/

\
 
 \ /
  Last update: 2024-05-27 16:47    [W:0.364 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site