lkml.org 
[lkml]   [2024]   [Apr]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v2 08/25] KVM: VMX: Initialize VMCS FRED fields
Date
> >+#ifdef CONFIG_X86_64
>
> is this #ifdeffery neccesary?

Yes, otherwise build fails on 32 bit.

>
> I assume kvm_cpu_cap_has(X86_FEATURE_FRED) is always false
> for !CONFIG_X86_64.
> Looks most of FRED changes in core kernel don't have such #ifdeffery.

Because it's not a compile time false, instead false from runtime.

>
> >+ /* Per-CPU FRED MSRs */
>
> Please explain why these six MSRs are updated here and why only they are updated in
> this comment.

The explanation is kind of implicit "per-CPU", I will make it more explicit

Thanks!
Xin

\
 
 \ /
  Last update: 2024-05-27 16:47    [W:0.067 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site