Messages in this thread | | | Date | Thu, 18 Apr 2024 17:04:58 +0300 | From | Andy Shevchenko <> | Subject | Re: [PATCH v2 resend] pinctrl: devicetree: fix refcount leak in pinctrl_dt_to_map() |
| |
On Thu, Apr 18, 2024 at 07:58:13PM +0800, Zeng Heng wrote: > If we fail to allocate propname buffer, we need to drop the reference > count we just took, otherwise it will lead reference leak. Here the > error exit path is modified to jump to the err label and call > pinctrl_dt_free_maps() which would drop the counter. > > In the meantime, if it is found that the property 'pinctrl-0' is not > present, ENODEV is returned and also jump to the err label and call the > free function, in case the Smatch tool complains.
..
> --- > v2: add a comment and modify the commit message, without any logical > changes.
You probably didn't get what I was saying... Linus already applied your version, what is missing is the comment. This should be done as a followup patch.
-- With Best Regards, Andy Shevchenko
| |