Messages in this thread | | | From | "Winiarska, Iwona" <> | Subject | Re: [PATCH v3 50/74] x86/cpu/vfm: Update drivers/hwmon/peci/cputemp.c | Date | Thu, 18 Apr 2024 13:32:15 +0000 |
| |
On Tue, 2024-04-16 at 23:57 +0000, Luck, Tony wrote: > > If the CPU defines and the new macro are to be kept in architecture code, > > maybe include arch/x86/include/asm/cpu_device_id.h from linux/peci.cpu.h. > > That would not be worse than today's include of intel-family.h. > > Guenter, > > Looks like I did that to resolve one of the other peci problems. Because I > already have: > > #include "../../arch/x86/include/asm/cpu_device_id.h" > #include "../../arch/x86/include/asm/intel-family.h" > > in <linux/peci_cpu.h> > > Simply deleting the include from cputemp.c builds OK in the > context of all the other changes in my patch series.
Hi Tony,
It won't build on non-x86, as cpu_device_id.h includes <asm/intel-family.h>. I think the simplest way to solve the issue is to provide a copy of VFM_* macros and X86_VENDOR_INTEL in include/linux/peci-cpu.h.
-Iwona
> > -Tony
| |