Messages in this thread | ![/](/images/icornerl.gif) | | Date | Thu, 18 Apr 2024 19:54:10 +0800 | Subject | Re: [PATCH v2] pinctrl: devicetree: fix refcount leak in pinctrl_dt_to_map() | From | Zeng Heng <> |
| |
在 2024/4/18 19:41, Andy Shevchenko 写道: > On Thu, Apr 18, 2024 at 07:34:59PM +0800, Zeng Heng wrote: >> If we fail to allocate propname buffer, we need to drop the reference >> count we just took, otherwise it will lead reference leak. Here the >> error exit path is modified to jump to the err label and call >> pinctrl_dt_free_maps() which would drop the counter. >> >> In the meantime, if it is found that the property 'pinctrl-0' is not >> present, ENODEV is returned and also jump to the err label and call the >> free function, in case the Smatch tool complains. >> --- > You forgot a changelog, but I think this needs to be a followup.
Oops, the resend patch would come soon.
Thanks,
Zeng Heng
| ![\](/images/icornerr.gif) |