Messages in this thread | | | Date | Thu, 18 Apr 2024 14:50:50 +0300 | From | Andy Shevchenko <> | Subject | Re: [PATCH v2] string_kunit: Add test cases for str*cmp functions |
| |
On Thu, Apr 18, 2024 at 12:30:33AM +0100, Ivan Orlov wrote: > Currently, str*cmp functions (strcmp, strncmp, strcasecmp and > strncasecmp) are not covered with tests. Extend the `string_kunit.c` > test by adding the test cases for them. > > This patch adds 8 more test cases: > > 1) strcmp test > 2) strcmp test on long strings (2048 chars) > 3) strncmp test > 4) strncmp test on long strings (2048 chars) > 5) strcasecmp test > 6) strcasecmp test on long strings > 7) strncasecmp test > 8) strncasecmp test on long strings > > These test cases aim at covering as many edge cases as possible, > including the tests on empty strings, situations when the different > symbol is placed at the end of one of the strings, etc.
LGTM, Reviewed-by: Andy Shevchenko <andy@kernel.org>
Thanks!
-- With Best Regards, Andy Shevchenko
| |