Messages in this thread | | | Date | Thu, 18 Apr 2024 17:07:54 +0800 | Subject | Re: [PATCH v2] ubi: block: fix memleak in ubiblock_create() | From | Li Nan <> |
| |
Hi, dan,
在 2024/4/15 14:33, Dan Carpenter 写道: > On Fri, Dec 08, 2023 at 03:46:29PM +0800, linan666@huaweicloud.com wrote: >> From: Li Nan <linan122@huawei.com> >> >> If idr_alloc() fails, dev->gd will be put after goto out_cleanup_disk in >> ubiblock_create(), but dev->gd has not been assigned yet at this time, and >> 'gd' will not be put anymore. Fix it by putting 'gd' directly. >> > > There is another invalid reference to dev->gd if blk_mq_alloc_tag_set() > fails. > > dev_err(disk_to_dev(dev->gd), "blk_mq_alloc_tag_set failed"); > ^^^^^^^ >
You are really very careful! I will fix it later.
> regards, > dan carpenter
-- Thanks, Nan
| |