Messages in this thread | | | Date | Thu, 18 Apr 2024 02:30:59 +0300 | From | Dmitry Baryshkov <> | Subject | Re: [PATCH 5/7] drm/msm/dpu: Correct dual-ctl -> dual-intf typo in comment |
| |
On Wed, Apr 17, 2024 at 01:57:45AM +0200, Marijn Suijten wrote: > This comment one line down references a single, "same CTL" that controls > two interfaces, so the comment should clearly describe two interfaces > used with a single active CTL and not "two CTLs". > > Fixes: 25fdd5933e4c ("drm/msm: Add SDM845 DPU support") > Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org> > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c > index d9e7dbf0499c..7e849fe74801 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c > @@ -428,7 +428,7 @@ static void dpu_encoder_phys_vid_enable(struct dpu_encoder_phys *phys_enc) > dpu_encoder_phys_vid_setup_timing_engine(phys_enc); > > /* > - * For single flush cases (dual-ctl or pp-split), skip setting the > + * For single flush cases (dual-intf or pp-split), skip setting the
It should be fixed, but in the other way: it's 'single-ctl'. See sde_encoder_phys_needs_single_flush().
> * flush bit for the slave intf, since both intfs use same ctl > * and HW will only flush the master. > */ > > -- > 2.44.0 >
-- With best wishes Dmitry
| |