lkml.org 
[lkml]   [2024]   [Apr]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v5 1/2] irqchip/gic-v3-its: Fix double free on error
From
I propose to improve the commit message another bit.

How do you think about to append the text “in its_vpe_irq_domain_alloc()”
to the summary phrase?


> In its_vpe_irq_domain_alloc, when its_vpe_init() returns an error
> with i > 0, its_vpe_irq_domain_free may free bitmap and vprop_page,
> and then there is a double free in its_vpe_irq_domain_alloc.

Can it be nicer to avoid the duplicate specification of a function name
in this change description?


> Fix it by calling its_vpe_irq_domain_free directly, bitmap and
> vprop_page will be freed in this function.

* Can the phrase “Fix it by” be omitted for an other imperative wording variant?

* Would you like to separate sentences by a dot instead of combining them
with a comma?

Regards,
Markus

\
 
 \ /
  Last update: 2024-05-27 16:44    [W:0.044 / U:0.640 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site