Messages in this thread | ![/](/images/icornerl.gif) | | Date | Thu, 18 Apr 2024 09:55:29 +0200 | Subject | Re: [PATCH v5 1/2] irqchip/gic-v3-its: Fix double free on error | From | Markus Elfring <> |
| |
I propose to improve the commit message another bit.
How do you think about to append the text “in its_vpe_irq_domain_alloc()” to the summary phrase?
> In its_vpe_irq_domain_alloc, when its_vpe_init() returns an error > with i > 0, its_vpe_irq_domain_free may free bitmap and vprop_page, > and then there is a double free in its_vpe_irq_domain_alloc.
Can it be nicer to avoid the duplicate specification of a function name in this change description?
> Fix it by calling its_vpe_irq_domain_free directly, bitmap and > vprop_page will be freed in this function.
* Can the phrase “Fix it by” be omitted for an other imperative wording variant?
* Would you like to separate sentences by a dot instead of combining them with a comma?
Regards, Markus
| ![\](/images/icornerr.gif) |