Messages in this thread | | | Date | Thu, 18 Apr 2024 14:40:44 -0400 | From | Willem de Bruijn <> | Subject | Re: [PATCH net v1 2/2] net: gro: add p_off param in *_gro_complete |
| |
Richard Gobert wrote: > Willem de Bruijn wrote:> Since this INDIRECT_CALL_INET needs to know about the definitions of > > udp4_lib_lookup_skb and udp6_lib_lookup_skb anyway, we can just get > > rid of the whole udp_lookup_t type and function pointer passing? > > > > Or move the entire lookup to udp4_gro_complete/udp6_gro_complete and > > pass the sk to udp_gro_complete. > > This sounds like a really good idea, I like it. Although I think it may be > more relevant to net-next instead of this bug fix. I can post a > complementing patch to net-next later if that's OK with you
That's fine.
This patch as is is already very intrusive for a net patch. For a fix, could we do something smaller? Like add the network offset into NAPI_GRO_CB in inet_gro_callback and use that in udp4_lib_lookup_skb? (and same for IPv6 of course).
| |