Messages in this thread | | | Date | Thu, 18 Apr 2024 21:00:44 +0300 | From | Dmitry Baryshkov <> | Subject | Re: [PATCH 2/2] usb: typec: qcom-pmic: fix pdphy start() error handling |
| |
On Thu, Apr 18, 2024 at 04:57:30PM +0200, Johan Hovold wrote: > Move disabling of the vdd-pdphy supply to the start() function which > enabled it for symmetry and to make sure that it is disabled as intended > in all error paths of pmic_typec_pdphy_reset() (i.e. not just when > qcom_pmic_typec_pdphy_enable() fails). > > Fixes: a4422ff22142 ("usb: typec: qcom: Add Qualcomm PMIC Type-C driver") > Signed-off-by: Johan Hovold <johan+linaro@kernel.org> > --- > drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_pdphy.c | 11 +++++++---- > 1 file changed, 7 insertions(+), 4 deletions(-)
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
-- With best wishes Dmitry
| |