lkml.org 
[lkml]   [2024]   [Apr]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/1] x86/pci: Skip early E820 check for ECAM region
On Wed, Apr 17, 2024 at 08:10:28PM -0700, Kuppuswamy Sathyanarayanan wrote:
>
> On 4/17/24 1:40 PM, Bjorn Helgaas wrote:
> > From: Bjorn Helgaas <bhelgaas@google.com>
> >
> > Arul, Mateusz, Imcarneiro91, and Aman reported a regression caused by
> > 07eab0901ede ("efi/x86: Remove EfiMemoryMappedIO from E820 map"). On the
> > Lenovo Legion 9i laptop, that commit removes the area containing ECAM from
> > E820, which means the early E820 validation started failing, which meant we
> > didn't enable ECAM in the "early MCFG" path
> ...

> LGTM
>
> Reviewed-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>

Thanks for taking a look!

> > - if (!early && !acpi_disabled) {
> > + if (early) {
> > +
> > + /*
> > + * Don't try to do this check unless configuration type 1
> > + * is available. How about type 2?
>
> I don't understand why above question is included in the comment. Do
> you think it is better to drop that part of the comment?

The "How about type 2?" questio was added by bb63b4219976 ("x86 pci:
remove checking type for mmconfig probe"). I only moved it and fixed
the capitalization and formatting.

> > - /* Don't try to do this check unless configuration
> > - type 1 is available. how about type 2 ?*/
> > - if (raw_pci_ops)
> > - return is_mmconf_reserved(e820__mapped_all, cfg, dev,
> > - "E820 entry");
> > -
> > return false;
> > }

\
 
 \ /
  Last update: 2024-05-27 16:46    [W:0.415 / U:0.212 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site