lkml.org 
[lkml]   [2024]   [Apr]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [patch V2 26/50] signal: Get rid of resched_timer logic
    On 04/11, Thomas Gleixner wrote:
    >
    > There is no reason for handing the *resched pointer argument through
    > several functions just to check whether the signal is related to a self
    > rearming posix timer.

    Agreed, these changes looks good to me.

    But,

    > SI_TIMER is only used by the posix timer code and cannot be queued from
    > user space.

    Why? I think sigqueueinfo() can certainly use si_code = SI_TIMER, so

    > @@ -1011,6 +1001,9 @@ static int __send_signal_locked(int sig,
    >
    > lockdep_assert_held(&t->sighand->siglock);
    >
    > + if (WARN_ON_ONCE(!is_si_special(info) && info->si_code == SI_TIMER))
    > + return 0;

    this can be easily triggered by userspace and thus looks wrong.

    Oleg.


    \
     
     \ /
      Last update: 2024-05-27 16:46    [W:2.653 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site