Messages in this thread | ![/](/images/icornerl.gif) | | Date | Thu, 18 Apr 2024 17:24:47 +0200 | Subject | Re: [PATCH 2/2] kunit: avoid memory leak on device register error | From | Markus Elfring <> |
| |
> If the device register fails, free the allocated memory before > returning.
* I suggest to use the word “registration” (instead of “register”) in the commit message.
* Would you like to add the tag “Fixes” accordingly?
> +++ b/lib/kunit/device.c > @@ -131,6 +131,7 @@ static struct kunit_device *kunit_device_register_internal(struct kunit *test, > err = device_register(&kunit_dev->dev); > if (err) { > put_device(&kunit_dev->dev); > + kfree(kunit_dev); > return ERR_PTR(err); > }
Common error handling code can be used instead if an additional label would be applied for a corresponding jump target.
How do you think about to increase the application of scope-based resource management here?
Regards, Markus
| ![\](/images/icornerr.gif) |