Messages in this thread | | | Subject | Re: [PATCH v2] wifi: ath11k: Fix error handling in ath11k_wmi_p2p_noa_event() | From | Kalle Valo <> | Date | Thu, 18 Apr 2024 15:20:32 +0000 (UTC) |
| |
Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote:
> if (noa_descriptors > WMI_P2P_MAX_NOA_DESCRIPTORS), there is a mix of > return and goto. In such a case, 'td' should be freed to avoid a memory > leak. > > While at it, change ath11k_wmi_p2p_noa_event() to return void. > '0' was returned in all cases, even in case of error and the only caller > does not handle the return value. > This is also more consistent with most of functions called from > ath11k_wmi_tlv_op_rx(). > > Fixes: 2408379f15a1 ("wifi: ath11k: implement handling of P2P NoA event") > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> > Acked-by: Jeff Johnson <quic_jjohnson@quicinc.com> > Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
Patch applied to ath-next branch of ath.git, thanks.
6ef5b4c9598c wifi: ath11k: Fix error handling in ath11k_wmi_p2p_noa_event()
-- https://patchwork.kernel.org/project/linux-wireless/patch/07f1fc75b2d5b4173ae1b7bb1da5be7f6fc608c8.1713212781.git.christophe.jaillet@wanadoo.fr/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
| |